-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom serializer support #80
base: master
Are you sure you want to change the base?
Conversation
PR Summary
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #80 +/- ##
===========================================
Coverage 100.00% 100.00%
- Complexity 55 57 +2
===========================================
Files 2 3 +1
Lines 148 152 +4
===========================================
+ Hits 148 152 +4 ☔ View full report in Codecov by Sentry. |
36cb676
to
afac545
Compare
Wouldn't it be better to add the interface to Otherwise everything seems very good, i would look for a better name for |
It's no needed for |
afac545
to
0813e4d
Compare
Renamed to |
Agree with @terabytesoftw. Good idea is move serilalizer interface to base package |
Allow custom, user defined serializers.
Igbinary
for example